Managerclient as submodule #4010
Conversation
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
6 times, most recently
from
a6e9fa5
to
6d1a719
Compare
Version and hearbeat endpoints are creating unnecessary dependencies in util pkg.
Service errors creates unnecessary dependencies in util
It removes unnecessary dependencies. By removing these dependencies it will be possible to create submodules for utils and managerclient.
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
4 times, most recently
from
4c625f4
to
4adcb5c
Compare
This commit extracts v3/pkg/util to explicit submodule, so that these utils are easily shared between main scylla-manager module and managerclient submodule.
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
4adcb5c
to
d14eed1
Compare
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
b8aefb9
to
774019f
Compare
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
9bb7fe1
to
64513d9
Compare
It's of preparation for substracting managerclient to separate submodule.
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
7b72167
to
0296912
Compare
…ent as submodule ...so that it can be imported to other project as go get github.com/scylladb/scylla-manager/v3/pkg/managerclient
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
0296912
to
df2d681
Compare
karol-kokoszka
force-pushed
the
managerclient-as-submodule
branch
from
ba8852b
to
6923d2f
Compare
|
@karol-kokoszka I understand that we want to wait for https://github.com/scylladb/siren/pull/11958 in order to validate correctness of this PR? |
Yes, I want to import dependency to siren first and validate it. |
|
Siren builds properly when the managerclient submodule is used as dependency only. Anyway, wants to merge it after the 3.3.2 patch fix. |
|
Scylla Cloud e2e passed https://jenkins.scylladb.com/view/siren/job/siren-jobs/job/siren-backend-e2e-manual/5696/ |
Fixes #4012
The goal is to extract managerclient as a separate submodule, so that it can be imported to other projects simply as
instead of importing full scylla-manager as dependency.
Doing the above is difficult if the repository uses google cloud SKD as a dependency, as our inhouse rclone (dependency to sm) uses replace directive on that lib to our inhouse google SDK....
Managerclient is intended to be used by Scylla Cloud.
Note:
Modules are named with v3/ prefix, to keep the backward compatibility with the imports.
v3/ prefix is added to the new path, as it must match the module name.
Please make sure that: